Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade marked to v5 #74

Merged
merged 5 commits into from
Aug 29, 2023

Conversation

nwaughachukwuma
Copy link
Contributor

@nwaughachukwuma nwaughachukwuma commented Jul 30, 2023

Summary

This PR includes an upgrade to marked, the base markdown parser library, from v4 to v5, and other minor refactoring.

P.S. I've replace rollup with Vite owing to the fact that

  1. Vite supports rollup as first class citizen and exposes rollup plugin interface.
  2. Svelte core also uses Vite
  3. To keep things consistent with Vitest.

Please let me know if you require the changes to the bundler as a separate PR.

@nwaughachukwuma nwaughachukwuma marked this pull request as draft July 30, 2023 07:08
@nwaughachukwuma nwaughachukwuma marked this pull request as ready for review July 30, 2023 09:58
@nwaughachukwuma nwaughachukwuma changed the title Upgrade markded to v5 Upgrade marked to v5 Jul 30, 2023
@nwaughachukwuma
Copy link
Contributor Author

cc @pablo-abc

@pablo-abc
Copy link
Owner

pablo-abc commented Jul 30, 2023

Thanks! I appreciate the change to Vite. I'll take a look at the rest of the changes later tonight.

@Niek
Copy link

Niek commented Aug 29, 2023

Any chance that this can be merged and released as a new version @pablo-abc?

@pablo-abc pablo-abc merged commit dfe2cc9 into pablo-abc:main Aug 29, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants