Address additional issues in conversion to pySBOL2 #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use description property to set descriptions, rather than breaking abstraction barrier
…ace, which is implicitly used when looking up parts by displayID. These are fragile assumptions of this tool and should be repaired.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The document copy operation is remapping items to their own namespace.
This doesn't appear to be necessary and unearthed a pySBOL2 bug (SynBioDex/pySBOL2#413).
I have also flagged an issue where there is an assumption about namespace hard-wired into the code which causes problems when it is not satisfied.
Cleaned up a few more abstraction breaks I came across as well.
(more work to address #1)