Update demo for pac4j 6.0.0 #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There might be an issue with Okta, but that's not a problem. In the demo, the version Is it normal? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the demo for the new version of ratpack-pac4j that supports pac4j 6.0.0. The PR for that upgrade is here: pac4j/ratpack-pac4j#14
Due to the Java 17 upgrade in pac4j 6.0.0, I had to remove the Groovy templating and replace it with a simple regex replace.
I'm not going to be terribly responsive over the holidays, so there's no rush. @jthurne and @gcoopercos can cover some of the time for me.
I was not able to test the Okta login because the login info was rejected by Okta.