Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(timezone): improve ux and time zone handling #100

Merged
merged 12 commits into from
Mar 22, 2024
Merged

feat(timezone): improve ux and time zone handling #100

merged 12 commits into from
Mar 22, 2024

Conversation

simonsan
Copy link
Contributor

No description provided.

@simonsan simonsan added A-ui-ux Area: Related to user interfaces and user experience C-enhancement Category: New feature or request C-refactor Category: Refactoring of already existing code labels Mar 20, 2024
simonsan added 11 commits March 21, 2024 09:59
@simonsan
chore: use cargo-autoinherit and move up the dependencies up to works…
1b87ba9 
…pace root

Signed-off-by: simonsan <[email protected]>
@simonsan
chore: factor out pace_time crate
9be4795 
Signed-off-by: simonsan <[email protected]>
@simonsan
fix: tests in pace_time
396a39d 
Signed-off-by: simonsan <[email protected]>
@simonsan
feat(timezone): more time zone related implementations
b6c6f01 
Signed-off-by: simonsan <[email protected]>
@simonsan
move tests
904b35d 
Signed-off-by: simonsan <[email protected]>
@simonsan
feat(timezone): implement more time zone related stuff
12c82d0 
Signed-off-by: simonsan <[email protected]>
@simonsan
test: fix tests
78bbded 
Signed-off-by: simonsan <[email protected]>
@simonsan
test: fix snapshots
fe8f70d 
Signed-off-by: simonsan <[email protected]>
@simonsan
fix: missing feature gate for import
9b5c826 
Signed-off-by: simonsan <[email protected]>
@simonsan
fix: update snapshots for ci
f5f27ba 
Signed-off-by: simonsan <[email protected]>
@simonsan
test: run timezone dependent snapshot tests only in CI
ebdf7cb 
Signed-off-by: simonsan <[email protected]>
@simonsan simonsan marked this pull request as ready for review March 22, 2024 17:34
@simonsan simonsan added this pull request to the merge queue Mar 22, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

Attention: Patch coverage is 40.84507% with 252 lines in your changes are missing coverage. Please review.

Project coverage is 42.8%. Comparing base (a592720) to head (ebdf7cb).

Additional details and impacted files
Files Coverage Δ
crates/core/src/commands.rs 100.0% <100.0%> (ø)
crates/core/src/commands/end.rs 0.0% <ø> (ø)
crates/core/src/commands/reflect.rs 0.0% <ø> (ø)
crates/core/src/domain/activity_log.rs 66.6% <ø> (ø)
crates/core/src/domain/filter.rs 64.7% <ø> (ø)
crates/core/src/domain/reflection.rs 10.2% <ø> (ø)
crates/core/src/error.rs 8.6% <ø> (ø)
crates/core/src/service/activity_store.rs 73.6% <ø> (ø)
crates/core/src/service/activity_tracker.rs 66.6% <ø> (ø)
crates/core/src/storage.rs 52.9% <ø> (ø)
... and 14 more

Merged via the queue into main with commit 7faa49e Mar 22, 2024
32 of 34 checks passed
@simonsan simonsan deleted the feat/timezones-ux branch March 22, 2024 17:46
@simonsan simonsan mentioned this pull request Mar 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-ui-ux Area: Related to user interfaces and user experience C-enhancement Category: New feature or request C-refactor Category: Refactoring of already existing code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@simonsan