Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(template): implement html and markdown templating for reflections #105

Merged
merged 9 commits into from
Mar 24, 2024

Conversation

simonsan
Copy link
Contributor

@simonsan simonsan commented Mar 23, 2024

Fixes #88

Copy link

codecov bot commented Mar 23, 2024

Codecov Report

Attention: Patch coverage is 14.28571% with 24 lines in your changes are missing coverage. Please review.

Project coverage is 46.1%. Comparing base (dc148ec) to head (3a27cda).

Additional details and impacted files
Files Coverage Δ
crates/core/src/domain/reflection.rs 10.2% <ø> (ø)
crates/core/src/error.rs 8.6% <ø> (ø)
crates/core/src/commands/reflect.rs 0.0% <0.0%> (ø)
crates/time/src/duration.rs 80.8% <66.6%> (+0.8%) ⬆️
crates/core/src/template.rs 8.3% <8.3%> (ø)

@simonsan simonsan changed the title feat(template): implement html templating for reflections feat(template): implement html and markdown templating for reflections Mar 24, 2024
@simonsan simonsan marked this pull request as ready for review March 24, 2024 13:19
@simonsan simonsan added C-enhancement Category: New feature or request A-templating Area: Related to our templating system labels Mar 24, 2024
@simonsan simonsan enabled auto-merge March 24, 2024 13:23
@simonsan simonsan added this pull request to the merge queue Mar 24, 2024
Merged via the queue into main with commit a042abb Mar 24, 2024
38 of 39 checks passed
@simonsan simonsan deleted the feat/templating branch March 24, 2024 13:45
@simonsan simonsan mentioned this pull request Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-templating Area: Related to our templating system C-enhancement Category: New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate tera templating and a first html template
1 participant