Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(item): Added ability to disable Command.Item from filtering #257

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Jamess-Lucass
Copy link

Fixes #107.

This adds a new property to the Command.Item component named shouldFilter, adding the ability to specify if certain Items should be except from filtering. This is helpful when certain command items are obtained via external filtering, for example, querying some search API and you do not want the response to be further filtered.

Copy link

vercel bot commented May 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cmdk-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 24, 2024 9:38pm

@Jamess-Lucass Jamess-Lucass marked this pull request as ready for review May 10, 2024 20:24
@Jamess-Lucass Jamess-Lucass changed the title feat(item): Added ability to disable Command.Item from being effected by feat(item): Added ability to disable Command.Item from filtering May 10, 2024
Copy link

@CruseCtrl CruseCtrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just realised that this functionality already exists by using the forceMount prop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Idea: shouldFilter per Group/Item
2 participants