Fix Rack 3 support #152
Merged
Fix Rack 3 support #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now Rack::Handler has been moved to a seperate gem, we need to specify it specifically. I’ve monkeypatched `Rack::Handler::WEBrick` to support both use cases everywhere in the gem
As of Rack `3.1.0`, `rack.input` is now optional, so cannot always be guaranteed to be present (https://github.com/rack/rack/blob/b4c92944e0dd04874bed36281fc8e1a44023677f/CHANGELOG.md?plain=1#L40)
This ensures we’re backwardsly compatible with both versions of Rack.
|
thanks for the pr @pezholio i’m travelling at the minute and just about to jump on a plane but will look at this probably Monday unless i get some time at the weekend |
|
Cool, thanks! 👍 |
|
Thanks for adding tests to cover both rack 2.x and 3.x. I can confirm the issue only occurs in rack 3.1.x which is why it didn't crop up before as part of #146 |
|
yarggg I've gotta double revert, because I don't have a changelog message for release and I don't want to force push on the main branch. |
This was referenced Jun 15, 2024
Merged
YOU54F
added a commit
to pact-foundation/pact_broker-client
that referenced
this pull request
Jun 15, 2024
YOU54F
added a commit
to pact-foundation/pact_broker-client
that referenced
this pull request
Jun 15, 2024
YOU54F
added a commit
to pact-foundation/pact-provider-verifier
that referenced
this pull request
Jun 15, 2024
This was referenced Jun 17, 2024
|
Hey, So I've got a couple of minor issues I think
I wonder if we need to relax the restriction on the latest gem to 2.x up to 4.x of Rack, without the use on an env var? That would mean there is a dep on rackup 2.x though |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #151
As of Rack > 3.1.0, the previous fixes for
Rack::Handler::WEBricknot being found have been removed. Additionally,rack.inputis now optional, so we can't guarantee thebodyvariable is there when reading the request in the mock service.I've also updated the CI to run with both Rack
2.x.xand3.x.x, so we can guarantee backwards compatibility. I imagine if we stopped support for Rack2.x.xcompletely this would cause issues with dependencies for some users.