[DEV-2094] refactor newsroom #1323
Open
+93
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarBert
requested review from
MarcoPonchia,
marcobottaro and
tommaso1
as code owners
🦋 Changeset detectedLatest commit: 19fabdf The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
marcobottaro
requested changes
Jan 24, 2025
apps/nextjs-website/src/components/organisms/NewsShowcase/NewsShowcase.tsx
Outdated
Show resolved
Hide resolved
Comment on lines
107
to
112
| img: tutorial.image | ||
| ? { | ||
| alt: tutorial.image?.alternativeText || '', | ||
| src: tutorial.image?.url || '/images/news.png', | ||
| } | ||
| : undefined, |
There was a problem hiding this comment.
I don't think you should modify this page. The Tutorial list page uses the same component, but is not meant to change
| @@ -54,6 +56,7 @@ const Item = (props: INewsroomItem) => { | |||
| href, | |||
| } = props; | |||
|
|
|||
| console.log(theme.palette); | |||
| borderRadius: 1, | ||
| maxHeight: '24px', | ||
| flexGrow: '0', | ||
| backgroundColor: '#C4DCF5', |
There was a problem hiding this comment.
We should look for the nearest color in theme palette
…Showcase.tsx Co-authored-by: marcobottaro <[email protected]>
Jira Pull Request LinkThis Pull Request refers to the following Jira issue DEV-2094 |
…per-portal into DEV-2094-refactor-newsroom
Jira Pull Request LinkThis Pull Request refers to the following Jira issue DEV-2094 |
|
Bundle not found for branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of Changes
Image is now optional, adds the label shown near the date.
Motivation and Context
Needed by DEV-2090
How Has This Been Tested?
On storybook
Screenshots (if appropriate):
Types of changes
Checklist: