Pin-5655: delete delegated consumer feature in BFF and in tenant process #1198
+373
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Eric Camellini <[email protected]>
Base automatically changed from
feature/Incaricato-tenant_PIN-5653
to
feature/incaricato
November 12, 2024 15:22
ecamellini
reviewed
Nov 12, 2024
…/pagopa/interop-be-monorepo into PIN-5655_deleteDelegatedConsumer
I've added the files but I'm not able to test it locally because I would need the route to add the flag, which is not yet implemented |
AsterITA
requested review from
beetlecrunch,
galales,
Carminepo2 and
taglioni-r
as code owners
ecamellini
reviewed
Nov 13, 2024
ecamellini
approved these changes
Nov 13, 2024
Co-authored-by: Eric Camellini <[email protected]>
Carminepo2
reviewed
Nov 13, 2024
Comment on lines
261
to
284
| function isFeatureAssigned( | ||
| tenant: Tenant, | ||
| featureType: TenantFeature["type"] | ||
| ): boolean { | ||
| return tenant.features.some((f) => f.type === featureType); | ||
| } | ||
|
|
||
| export function assertFeatureNotAssigned( | ||
| tenant: Tenant, | ||
| featureType: TenantFeature["type"] | ||
| ): void { | ||
| if (isFeatureAssigned(tenant, featureType)) { | ||
| throw tenantAlreadyHasFeature(tenant.id, featureType); | ||
| } | ||
| } | ||
|
|
||
| export function assertFeatureAssigned( | ||
| tenant: Tenant, | ||
| featureType: TenantFeature["type"] | ||
| ): void { | ||
| if (tenant.features.some((f) => f.type === "DelegatedProducer")) { | ||
| throw tenantAlreadyHasDelegatedProducerFeature(tenant.id); | ||
| if (!isFeatureAssigned(tenant, featureType)) { | ||
| throw tenantDoesNotHaveFeature(tenant.id, featureType); | ||
| } | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes PIN-5655