IMN-710 - selfcare-onboarding-consumer #959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecamellini
changed the title
ecamellini
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
packages/selfcare-onboarding-consumer/test/selfcareOnboardingProcessor.test.ts
Fixed
Show fixed
Hide fixed
ecamellini
requested review from
micdes-pagopa,
beetlecrunch,
galales,
AsterITA,
Carminepo2 and
taglioni-r
as code owners
ecamellini
commented
Sep 23, 2024
| @@ -23,7 +23,6 @@ | |||
| "@pagopa/eslint-config": "3.0.0", | |||
| "@types/node": "20.14.6", | |||
| "@types/uuid": "9.0.8", | |||
| "openapi-endpoint-trimmer": "2.0.0", | |||
There was a problem hiding this comment.
Unused everywhere
AsterITA
reviewed
Sep 23, 2024
AsterITA
reviewed
Sep 23, 2024
packages/selfcare-onboarding-consumer/src/services/selfcareOnboardingProcessor.ts
Outdated
Show resolved
Hide resolved
…oardingProcessor.ts Co-authored-by: AsterITA <[email protected]>
AsterITA
approved these changes
Sep 23, 2024
beetlecrunch
approved these changes
Sep 23, 2024
Viktor-K
approved these changes
Sep 24, 2024
micdes-pagopa
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes IMN-710
Closes IMN-718
Closes IMN-725
Description
This PR ports the Selfcare Onboarding Consumer from the reports repo to the monorepo: https://github.com/pagopa/interop-be-reports/tree/1.0.x/jobs/selfcare-onboarding-consumer
The job was adapted to match the standards and architecture of the monorepo (config, dockerfile, tests, etc.) and to reuse, where possible, models and commons from the monorepo.
Tests
Automated tests pass:
