IMN 707 - IVASS Certified attributes importer #963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MalpenZibo
changed the base branch from
main
to
IMN-704_anac-certified-attributes-importer
MalpenZibo
force-pushed
the
IMN-707_ivass-certified-attributes-importer
branch
from
a9e78a4
to
1e7d110
Compare
MalpenZibo
force-pushed
the
IMN-704_anac-certified-attributes-importer
branch
from
934262e
to
118f7bf
Compare
MalpenZibo
force-pushed
the
IMN-707_ivass-certified-attributes-importer
branch
from
1e7d110
to
8bf1416
Compare
MalpenZibo
commented
Sep 17, 2024
There was a problem hiding this comment.
I'm not sure which default values should be used here
MalpenZibo
force-pushed
the
IMN-707_ivass-certified-attributes-importer
branch
from
8bf1416
to
6555843
Compare
MalpenZibo
commented
Sep 17, 2024
There was a problem hiding this comment.
this is identical to the one created for the anac certified attributes importer. Maybe we could move this implementation in the common package packages/anac-certified-attributes-importer/src/service/tenantProcessService.ts
MalpenZibo
force-pushed
the
IMN-707_ivass-certified-attributes-importer
branch
from
cd507de
to
cdccc64
Compare
MalpenZibo
requested review from
Viktor-K,
ecamellini,
sandrotaje and
paologaleotti
MalpenZibo
requested review from
beetlecrunch,
galales,
AsterITA,
Carminepo2 and
taglioni-r
as code owners
MalpenZibo
force-pushed
the
IMN-707_ivass-certified-attributes-importer
branch
from
38f385a
to
8dc07f5
Compare
MalpenZibo
force-pushed
the
IMN-707_ivass-certified-attributes-importer
branch
from
8dc07f5
to
8545436
Compare
MalpenZibo
force-pushed
the
IMN-704_anac-certified-attributes-importer
branch
from
1e99d3c
to
22b4395
Compare
MalpenZibo
force-pushed
the
IMN-707_ivass-certified-attributes-importer
branch
from
8545436
to
f4d88bf
Compare
micdes-pagopa
approved these changes
Sep 17, 2024
MalpenZibo
commented
Sep 17, 2024
| @@ -44,6 +44,12 @@ export type FileManager = { | |||
| }, | |||
| logger: Logger | |||
| ) => Promise<string>; | |||
| storeBytesByPath: ( | |||
There was a problem hiding this comment.
use @Viktor-K implementation
Viktor-K
requested changes
Sep 17, 2024
There was a problem hiding this comment.
I leave minor comments, you can ignore if not relevant, except for one related to aws.config.local useful for S3 local configuration.
MalpenZibo
force-pushed
the
IMN-707_ivass-certified-attributes-importer
branch
from
d5ae34d
to
9922170
Compare
MalpenZibo
force-pushed
the
IMN-704_anac-certified-attributes-importer
branch
from
9390b3d
to
4f1a591
Compare
MalpenZibo
force-pushed
the
IMN-707_ivass-certified-attributes-importer
branch
from
a966a2b
to
72d58b3
Compare
MalpenZibo
force-pushed
the
IMN-704_anac-certified-attributes-importer
branch
from
4f1a591
to
38c6f07
Compare
MalpenZibo
force-pushed
the
IMN-707_ivass-certified-attributes-importer
branch
from
72d58b3
to
ec1b65d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes IMN-707
This PR ports ivass certified attributes importer (with automated test). Configuration, naming convention, and docker config have been changed to adapt to the new codebase.