Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IOPLT-699] Update API_KEY var name and OpenAPI url to generate trial system client #1150

Merged
merged 4 commits into from
Oct 1, 2024

Conversation

kin0992
Copy link
Contributor

@kin0992 kin0992 commented Sep 19, 2024

List of Changes

  • Change environment name to TRIAL_SYSTEM_APIM_KEY
  • Get TRIAL_SYSTEM_APIM_BASE_PATH variable
  • Pass basePath variable when generating the client
  • Change OpenAPI URL used to generate client

Important

This PR depends on pagopa/trial-system#197 which ensure the user group of the APIM subscription used by the backend can access to the endpoints.
This depends on pagopa/io-infra#1176 pagopa/io-infra#1191 pagopa/io-infra#1192 as well, which add the environment variables.

Motivation and Context

We are going to migrate the trial system calls through the APIM.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link

github-actions bot commented Sep 19, 2024

Jira Pull Request Link

This Pull Request refers to the following Jira issue IOPLT-699

@kin0992 kin0992 force-pushed the features/update-trial-system-config branch from c361bec to 167c056 Compare September 24, 2024 07:55
@kin0992 kin0992 force-pushed the features/update-trial-system-config branch from 167c056 to 7c2ed5f Compare September 24, 2024 07:56
Copy link

dpulls bot commented Sep 24, 2024

🎉 All dependencies have been resolved !

@kin0992 kin0992 force-pushed the features/update-trial-system-config branch from 30b0634 to 385125c Compare September 24, 2024 10:00
@kin0992 kin0992 force-pushed the features/update-trial-system-config branch from 385125c to 4ec0c51 Compare September 24, 2024 10:01
Copy link

dpulls bot commented Sep 26, 2024

🎉 All dependencies have been resolved !

Copy link

sonarcloud bot commented Sep 26, 2024

Copy link

dpulls bot commented Sep 26, 2024

🎉 All dependencies have been resolved !

@kin0992 kin0992 marked this pull request as ready for review September 26, 2024 14:41
@kin0992 kin0992 requested a review from a team as a code owner September 26, 2024 14:41
@AleDore AleDore merged commit 8995901 into master Oct 1, 2024
9 checks passed
@AleDore AleDore deleted the features/update-trial-system-config branch October 1, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants