-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [OI-204] vite migration #446
base: main
Are you sure you want to change the base?
Conversation
mmoio
commented
Oct 18, 2024
•
edited
Loading
edited
- Remove craco dependencies and configuration
- adds vite dependencies and configuration
- refactored envs to work with vite
- Replaces REACT_APP with VITE as env prefixes
- removes env-var and use vite import.meta
52209ee
to
e1d3beb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Env file should respect the short environment names. This is mostly due to CIs which use this mapping to run trough envs.
So, I suggest to rename back .env.production
to .env.prod
and .env.development
to .env.dev
I'should ve explained this changes better in the pr description, but vite uses some defaults when loading env files, some documentation regarding this argument in this page https://vite.dev/guide/env-and-mode. One of this default behaviours is loading a |
424b7c7
to
1c66cc8
Compare
For simplicity sake, I've changed back the environment files back to the original names, so to keep the pipeline environments coherent with the other parts of the project. |
Thanks for the clarification, now I have a more comprehensive view. Here you can find the deployment pipeline which will build and ship the frontend stuff. This line will load the environment from matrix (which it can be one from "dev|uat|prod", line 17) and build the app: |
- changes .env.local to .env.development - updates and adds commands to package.json - updates .gitignore and fe deploy pipeline - updates tsconfig - updates vite configs - updates index.tsx
1c66cc8
to
cd9beb5
Compare