Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix loading of password secured private key #268

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix loading of password secured private key #268

wants to merge 1 commit into from

Conversation

mortbauer
Copy link

I had the problem that sshtunnel would not use the provided password to load the private key.
This pulll request fixed it.

sasa821
sasa821 reviewed Feb 8, 2023
View reviewed changes
Copy link

@sasa821 sasa821 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have the same problem loading private keys with a password; this PR will solve the problem. Thank you! I hope it gets merged soon.

sshtunnel.py
@@ -1315,6 +1317,7 @@ def read_private_key_file(pkey_file,
if logger:
logger.error('Password is required for key {0}'
.format(pkey_file))
raise
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this line necessary?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sasa821 sasa821 sasa821 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mortbauer @sasa821