Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pick_phylopic no longer prints attribution information in menu #104

Closed
willgearty opened this issue Mar 11, 2024 · 0 comments · Fixed by #105
Closed

pick_phylopic no longer prints attribution information in menu #104

willgearty opened this issue Mar 11, 2024 · 0 comments · Fixed by #105
Assignees
@LewisAJones
Labels
bug
Milestone
1.4.0

Comments

@willgearty
Copy link
Collaborator

willgearty commented Mar 11, 2024 •
edited
Loading

#100 changed the output of get_attribution, and pick_phylopic wasn't updated accordingly:
image
This also brings to light an issue where we aren't currently able to test the menu contents of pick_phylopic. Is there a way to better test this interactive function? Maybe pull out some of the functionality to another non-interactive function that we can then test?
@willgearty willgearty added the bug label Mar 11, 2024
@willgearty willgearty added this to the 1.4.0 milestone Mar 11, 2024
LewisAJones added a commit that referenced this issue Mar 11, 2024
@LewisAJones
Fix #104
02c78d1
@LewisAJones LewisAJones mentioned this issue Mar 12, 2024
Merged
@LewisAJones LewisAJones linked a pull request Mar 12, 2024 that will close this issue
Fix attribution display in pick_phylopic #105
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LewisAJones LewisAJones

Labels
bug
Projects
None yet
Milestone
1.4.0
Development

Successfully merging a pull request may close this issue.

Fix attribution display in pick_phylopic palaeoverse/rphylopic
2 participants
@willgearty @LewisAJones