Fix attribution display in pick_phylopic #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willgearty
approved these changes
Mar 12, 2024
NEWS.md
Outdated
| @@ -2,6 +2,7 @@ | |||
|
|
|||
| * Added add_phylopic_legend (#83) | |||
| * Added permalink generation option to get_attribution (#81) | |||
| * Fix pick_phylopic attribution display bug (#104) | |||
There was a problem hiding this comment.
Should it be reported in NEWS.md if we introduced the bug and fixed the bug between releases?
There was a problem hiding this comment.
Maybe not, I guess many users don't use the development version?
There was a problem hiding this comment.
Yeah, I doubt many people do, and I think this might just cause more confusion for those that don't (not that too many people are going to read the changelog anyways).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes bug #104, which results in attribution information not being displayed in the
pick_phylopicinteractive menu. To enable tests to catch such a bug in the future, I've added an additional test. This test relies on an update to theautoargument which allows a list of the attribution information to be directly returned.Fixes #104.