Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tracing-java integration #603

Draft
wants to merge 18 commits into
base: palantir-cassandra-2.2.18
Choose a base branch
from
Draft

Add tracing-java integration #603

wants to merge 18 commits into from

Conversation

jkozlowski
Copy link

@jkozlowski jkozlowski commented Jan 15, 2025 •
edited
Loading

Diff is large cause generated code is checked in.

Log

  • Cannot upgrade tracing-java, because newer version are compiled with newer Java.
  • This whole setup is VERY SHAKEY, because we compile cassandra here with old tracing, but run internally with new tracing, possibly. I still don't quite understand what the actual jar on the classpath would be.

To mitigate these, I am trying to use as old and low level API as I can.

  • thrift: somehow managed to compile old 0.17 thrift to be able to regenerate the interfaces. There is no way to insert middleware in TBinary thrift transport.

zpear
zpear previously approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@zpear zpear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rc

@jkozlowski jkozlowski marked this pull request as draft January 16, 2025 16:50
@policy-bot policy-bot bot dismissed zpear’s stale review January 16, 2025 16:51

Invalidated by push of 6f24054

@jkozlowski jkozlowski changed the title Add tracing-java dependency Add tracing-java integration Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zpear zpear zpear left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
do not merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jkozlowski @zpear @svc-autorelease