Add safe logging arguments to StorageService #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhuffy
approved these changes
Jan 22, 2025
Comment on lines
+1122
to
+1123
| logger.warn("Some data streaming failed. Use nodetool to check bootstrap state and resume. For more, see `nodetool help bootstrap`. {}", | ||
| SafeArg.of("", SystemKeyspace.getBootstrapState())); |
Comment on lines
-3782
to
+3810
| logger.info("Combining new repair request with in-progress (identical) repair command #{}", cmd); | ||
| logger.info("Combining new repair request with in-progress (identical) repair command #{}", UnsafeArg.of("command", cmd)); |
There was a problem hiding this comment.
cmd is an int, so this is probably safe, right?
| InetAddress preferred = SystemKeyspace.getPreferredIP(address); | ||
| streamPlan.requestRanges(address, preferred, keyspace, workMap.get(address)); | ||
| } | ||
|
|
||
| logger.debug("Keyspace {}: work map {}.", keyspace, workMap); | ||
| // This log line seems unnecessary given the above loop... |
There was a problem hiding this comment.
maybe, but I do think in grafana it's easier to analyze a single log line instead of combining multiple, especially when multiple nodes are reporting the logs simultaneously
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.