Skip to content

Commit

Permalink
Singleton beans use a JsonCreator with mode=PROPERTIES
Browse files Browse the repository at this point in the history
See the discussion here:
FasterXML/jackson-databind#4688 (comment)

Ideally we can avoid deserialization failures for existing code,
but it's better to align our usage with the maintainers vision
either way :-)
  • Loading branch information
carterkozak committed Sep 5, 2024
1 parent 19d7f54 commit 413a442
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -405,7 +405,7 @@ private static MethodSpec createStaticFactoryMethodForEmptyBean(ClassName object
return MethodSpec.methodBuilder("of")
.addModifiers(Modifier.PUBLIC, Modifier.STATIC)
.returns(objectClass)
.addAnnotation(ConjureAnnotations.delegatingJsonCreator())
.addAnnotation(ConjureAnnotations.propertiesJsonCreator())
.addCode("return $L;", SINGLETON_INSTANCE_NAME)
.build();
}
Expand Down

0 comments on commit 413a442

Please sign in to comment.