Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the GO111MODULE=off env var from go list #415

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Remove the GO111MODULE=off env var from go list #415

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c42df1d
Remove the `GO111MODULE=off` env var from go list
jamestoyer Oct 24, 2023
ecb5576
Update configdefaults.go
jamestoyer Oct 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions distgo/config/configdefaults.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
package config

import (
"os"
"os/exec"
"path"
"path/filepath"
Expand Down Expand Up @@ -175,9 +174,6 @@ func mainPkgPaths(projectDir string, exclude matcher.Matcher) ([]string, error)
func runGoList(dir string, args ...string) ([]string, error) {
goListCmd := exec.Command("go", append([]string{"list"}, args...)...)
goListCmd.Dir = dir
// explicitly set module mode to "off" -- "go list" is being used to determine main packages, and running in
// non-module mode is more flexible for this purpose (even when dealing with modules).
goListCmd.Env = append(os.Environ(), "GO111MODULE=off")
outputBytes, err := goListCmd.CombinedOutput()
output := string(outputBytes)
if err != nil {
Expand Down