Add dynamic heap percentage #323
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Probably going to do #324 first and start gathering data before adding anything around the scaling function |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
Currently, we set the RAM Percentage to 75% in all scenarios, which leads to a reasonable amount of waste in cases where we have large memory resource requests or limits. We should attempt to make this value dynamic based on the size of the cgroup that we're running in.
After this PR
==COMMIT_MSG==
Add dynamic heap percentage system property
==COMMIT_MSG==
Possible downsides?
Definitely need to play around with the function... have no idea what a good approach is 🙃