Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Vue3 using compat release #88

Merged
merged 7 commits into from
Dec 14, 2021
Merged

Conversation

paulgoetze
Copy link
Member

@paulgoetze paulgoetze commented Dec 10, 2021

Duplicate of PR #85 with some additional fixes.

Thanks @pascalwengerter for the ground work! 🙌. For some reason i18n worked now - maybe some fixes where made meanwhile.

I was not sure how to get my fixes on top of yours, so I just copied your branch from your fork & opened this new PR.

Fixes #83
Fixes #85

@pascalwengerter
Copy link
Collaborator

Awesome, will take a look over the weekend 🥰

src/router/index.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like charm for me

@paulgoetze paulgoetze merged commit 9dc6c65 into main Dec 14, 2021
@paulgoetze paulgoetze deleted the try-vue3-compat-release branch December 14, 2021 15:13
@pascalwengerter pascalwengerter mentioned this pull request Dec 14, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to Vue3
3 participants