Merge pull request #109 from palladians/fix/fix-wrong-password-bricking

fix(wallet): fix wrong password reopen brick
palladians · Dec 23, 2023 · f8a2a0c · f8a2a0c
2 parents 8fe0550 + c068e12
commit f8a2a0c
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 7 deletions.
diff --git a/packages/features/src/lock/views/unlock-wallet.tsx b/packages/features/src/lock/views/unlock-wallet.tsx
@@ -5,7 +5,7 @@ import {
 } from '@palladxyz/persistence'
 import { useVault } from '@palladxyz/vault'
 import { EyeIcon, EyeOffIcon } from 'lucide-react'
-import { useEffect, useState } from 'react'
+import { FormEvent, useEffect, useState } from 'react'
 import { useForm } from 'react-hook-form'
 import { useNavigate } from 'react-router-dom'
 import { z } from 'zod'
@@ -59,6 +59,10 @@ export const UnlockWalletView = () => {
       })
     }, 100)
   }
+  const togglePassword = (event: FormEvent<HTMLButtonElement>) => {
+    event.preventDefault()
+    setShowPassword(!showPassword)
+  }
   useEffect(() => {
     const unsub = useVault.persist.onFinishHydration(async () => {
       const authenticated =
@@ -127,7 +131,7 @@ export const UnlockWalletView = () => {
                     variant="outline"
                     size="icon"
                     data-testid="unlockWallet__togglePasswordVisible"
-                    onClick={() => setShowPassword(!showPassword)}
+                    onClick={togglePassword}
                   >
                     {showPassword ? <EyeOffIcon /> : <EyeIcon />}
                   </Button>

diff --git a/packages/features/src/onboarding/views/start.tsx b/packages/features/src/onboarding/views/start.tsx
@@ -17,12 +17,21 @@ export const StartView = () => {
   useEffect(() => {
     const initialRedirect = async () => {
       if (!isStoreInitialized) return setAppInitialized(true)
-      const spendingPassword =
-        (await getSessionPersistence().getItem('spendingPassword')) || ''
-      const spendingPasswordSet = spendingPassword.length > 0
+      let spendingPassword
+      try {
+        spendingPassword =
+          (await getSessionPersistence().getItem('spendingPassword')) || ''
+      } catch {
+        return navigate('/unlock')
+      }
+      const spendingPasswordSet = spendingPassword?.length > 0
       if (!spendingPasswordSet) return navigate('/unlock')
-      const authenticated =
-        (await getSecurePersistence().getItem('foo')) === 'bar'
+      let authenticated
+      try {
+        authenticated = (await getSecurePersistence().getItem('foo')) === 'bar'
+      } catch {
+        authenticated = false
+      }
       if (!authenticated) return navigate('/unlock')
       return navigate('/dashboard')
     }