Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add mina_requestAccounts provider method and return an empty ar… #217

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

DeMonkeyCoder
Copy link
Contributor

This PR is made to add mina_requestAccounts provider method and return an empty array in response to mina_accounts if the wallet is not connected.

I tried to make minimum changes to the code, but it's better if this is managed by a complete permission system in the wallet

Copy link

deepsource-io bot commented Oct 22, 2024

Here's the code health analysis summary for commits a814f80..291f345. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ Success
❗ 1 occurence introduced
🎯 1 occurence resolved
View Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@DeMonkeyCoder DeMonkeyCoder force-pushed the feat/mina-request-accounts branch from 1c8ad4b to 9db3adf Compare October 22, 2024 22:13
…ray in response to mina_accounts if the wallet is not connected
@DeMonkeyCoder DeMonkeyCoder force-pushed the feat/mina-request-accounts branch from 9db3adf to 4276aee Compare October 22, 2024 22:30
@mrcnk mrcnk merged commit bf49ce1 into palladians:main Oct 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants