-
-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pre-commit, style linting with ruff #208
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wlach
force-pushed
the
add-ruff-style-lints
branch
3 times, most recently
from
May 20, 2024 17:31
71be0a0
to
04d9c13
Compare
wlach
commented
May 20, 2024
string_types = basestring, | ||
text_type = unicode | ||
message_policy = None | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Snipping all of this out and/or inlining it, we only support Python 3.8+ now
wlach
commented
May 20, 2024
wlach
commented
May 20, 2024
Again, mostly copied from the approach used in flask-debugtoolbar.
for more information, see https://pre-commit.ci
wlach
force-pushed
the
add-ruff-style-lints
branch
from
May 20, 2024 17:45
04d9c13
to
3b83e96
Compare
@dependabot rebase |
aenglander
requested changes
May 20, 2024
wlach
force-pushed
the
add-ruff-style-lints
branch
from
May 20, 2024 19:14
c3a5858
to
7392e08
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Again, mostly copied from the approach used in
flask-debugtoolbar.