Fixed duplication of identifiers in form fields layout (macro) #1049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Besides fixing whatever is wrong :-) could you separate out the translations commit from the macros PR (or don't worry about the translations - I'll do that as part of getting the release ready). The translations really mask what the actual change is all about. Thanks - yes - this is a good change. |
|
Maybe we should call the container id {{field-id}}-container |
|
Looks like you got busy. I have a slightly different solution - will include you on PR review when I get it done. Thanks! |
|
Yes, I've been away and out of touch, I apologize for the long wait. If it is still relevant, I can prepare a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes fix the rendering of form fields (previously, the wrapper IDs for form fields were duplicated with the IDs of the fields themselves). Now labels to these form fields will work in the browser when clicked.
upd: I've also updated the translations...