Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release candidate 0.6.0-rc1 #208

Merged
merged 38 commits into from
Feb 2, 2024
Merged

release candidate 0.6.0-rc1 #208

merged 38 commits into from
Feb 2, 2024

Conversation

Lxstr
Copy link
Contributor

@Lxstr Lxstr commented Jan 16, 2024

Includes code from many PRs and issues over the lifetime of the project in order to fix most major issues.

Refactor in a way that aligns each backend and makes adding new backends or contributing easier.

The issues of serialization, more backends and regeneration have been left aside for now.

Tests are not yet thorough or well structured but will be done.

This is a release candidate intended for community test usage and feedback.

idoshr and others added 30 commits April 25, 2023 12:10
Fix for Redis / mongo/memcache/filesystem 
Not for sql
Do not save session on each request if session.modified = False
- Marked previously failing tests as SKIP as fixing them is outside the
  scope of this issue.
- Updated pyproject.toml to be able to run the tests
- Updated github actions to run tests
- Tests moved to tests directory
- Testing done via pytest
- Created requirements/pytest.txt for running pytest
- Main code changes based on review
add should_set_cookie check before save new cookies
Version
Previous lack of SECRET_KEY with SESSION_USE_SIGNER=True was:
AttributeError: 'NoneType' object has no attribute 'sign'

Now it is:
KeyError: 'SECRET_KEY must be set when SESSION_USE_SIGNER=True'

Closed #189
Closes #203
Based on flask-session2 rather than other PRs as the expected behaviour would be to remove the session with no expiry
save_session method relies on checking if a session is empty to return early. This fixes the boolean evaluation of a permanent but empty session evaluating as True.

Closes #193
Use secrets module for session ids
Pymongo fixes from flask-session2 and #183 #199 #136
Fix bare except statement
@Lxstr Lxstr marked this pull request as ready for review January 16, 2024 03:29
@Lxstr Lxstr merged commit 41e2771 into main Feb 2, 2024
14 checks passed
@Lxstr Lxstr deleted the development branch February 2, 2024 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants