Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aclose root_render_func in generate_async #1958

Closed
wants to merge 3 commits into from
Closed

aclose root_render_func in generate_async #1958

wants to merge 3 commits into from

Conversation

graingert
Copy link
Contributor

@graingert graingert commented Apr 7, 2024 •
edited
Loading

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

graingert
graingert commented Apr 7, 2024
View reviewed changes
CHANGES.rst Outdated Show resolved Hide resolved
@graingert graingert marked this pull request as ready for review April 7, 2024 17:27
@davidism
Copy link
Member

davidism commented May 11, 2024 •
edited
Loading

Superseded by #1960

@davidism davidism closed this May 11, 2024
@graingert graingert deleted the aclose-render-root-agen branch May 11, 2024 21:17
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

root_render_func not properly aclosed in Template.generate_async
2 participants
@graingert @davidism