[change] Removed DeviceLocation endpoints

- Chnaged the endpoints pattern
- Removed tests for `DeviceLocation` endpoints
- Updated docs with new pattern of endpoints

[api] Updated the `devicelocation` view in `GEO` app endpoint

[api] Added the delete option for the `device_location` endpoint

[docs] Added `delete` in the device location API documentation

[fix] Context variable follows template order openwisp#484

If two or more applied templates have "default_values" with same keys,
then the context variables of the template with comes later in order
will be used.

Fixes openwisp#484

Co-authored-by: Federico Capoano <[email protected]>

[feature] Added support for ED25519 SSH keys

Additionally shows a validation error if the private key
being inserted during credential creation is invalid or
not supported (supporting only RSA and ED25519 since they're
the widely accepted secure algorithms).

[feature] Allow searching for address in Device Admin

[change] Execute credentials auto_add in the background openwisp#479

Closes openwisp#479

[feature] Added device groups openwisp#203

A group can be specified for devices, i.e. DeviceGroup.
DeviceGroup can contain metadata about group of devices in JSON format.
JSONSchema can be set systemwide for validating and building the UI users will use to fill the metadata.

Added REST API endpoint for listing, creating and retrieving DeviceGroups.

Implements and closes openwisp#203

[feature] Added connection app REST API  openwisp#464

Closes openwisp#464

[deps] Increased min django-flat-json version to 0.1.3 openwisp#502

Fixes openwisp#502

[chores] Admin improvements for groups

- added group filter in device list
- added description and meta_data to search_fields

[feature] Added REST API for PKI app (certs and CAs) openwisp#462

Implements and closes openwisp#462

[feature] Add API endpoint to return device group info based on the certificate common name openwisp#491

- [change!] Common name and Organization unique together for Cert and Ca models
- [deps] Added shortuuid~=1.0.1
- [feature] Added API endpoint to return device group using certificate common name openwisp#491

Closes openwisp#491

[fix] Fixed JSONSchema editor select2 fields getting disabled openwisp#505

The issue arose because the JSON Schema library uses selec2('enable') for
enabling or disabling select2 fields. According to the "Migrating from 3.5" section
in select2 documentation, select2('enable') has been deprecated.
The solution is to override the methods using it to simply modify
select2.disabled property.

Closes openwisp#505

[fix] Fixed advanced editor quirks openwisp#506

Bugs fixed:
- Executing a command, would raise a 'Invalid JSON' alert in the
  advance mode of the configuration even if the JSON is valid
- The device page deals with two schema and the container for
  advance mode editor used 'id="advanced_editor"'. Fetching the advance
  mode editor using the 'id' always returned the first occurence
  (advance mode editor of configuration). This used to create multiple
  advance mode editor DOM elements inside the container all of which
  had their own event listeners. Hence, full screen toggling was not
  working properly.

Closes openwisp#506

[fix] JSONSchema Editor maxlength modification handle non-existent schema objects openwisp#353

Related to openwisp#353

[change] Switch to new nav menu openwisp#472

Closes openwisp#472

[api] Re-introduced `DeviceLocation` endpoints

[api] Upgraded existing Device Location endpoint

[tests] Added tests for device location endpoint

[change] Minor code improvements

[tests] Added tests for changing location detail and coordinates

[api] Added support of creating a floorplan along with location

[api] Added update method to `Location` serializer

[api] Added support of creating/updating floorplan with location

[change] Added option to change device location detail with token

[tests] Added tests for create location endpoint of indoor type

[change] Minor bug fix and added tests for the endpoints

[tests] Minor typo fix

[change] Improved docs & optimized number of queries

[docs] Improvement in the docs related to devicelocation endpoint

[api] Fixed device location endpoint added TokenAuthentication

[docs] Updated info on how to use the device location endpoints

[change] Added tests and improved devicelocation permission logic

[change] Fixed the validation error raised due to image format

[change!] Removed the creation of devicelocation with GET request

[fix] Included PKI API URLs to `controller.urls` file openwisp#511

Closes openwisp#511

[chores] Ensure Device.group.verbose_name is lowercase for consistency

[fix] Fixed 0010 pki migration when cert serial_number is None

[fix] CommandFailedException: ensure error message is always present

If a command with suppressed output failed, CommandFailedException
would be raised with an emptry string as argument, which makes
debugging issues really hard.

In this cases we shall instantiate the exception with the same
message passed to the log.

[fix/tests] TestSsh: fixed assert_has_calls not being called

I found out these assertions were not being called while working
on the previous commit.

[fix] Registered menu group in connection app openwisp#512

Closes openwisp#512

[fix] Fixed new theme issues in config editor and command inputs

Co-authored-by: Federico Capoano <[email protected]>

[test] Fixed failing tests due to openwisp-utils menu changes

Co-authored-by: Pedro Peña <[email protected]>

[docs] Updated docs about limitations of device location endpoint

[tests] Fixed tests causing CI to fail

README.rst

@@ -1005,167 +1005,201 @@ of certificate's organization as show in the example below:
 
     GET /api/v1/controller/cert/{common_name}/group/?org={org1_slug},{org2_slug}
 
-Get device coordinates
-^^^^^^^^^^^^^^^^^^^^^^
+Get device location
+^^^^^^^^^^^^^^^^^^^
 
 .. code-block:: text
 
     GET /api/v1/controller/device/{id}/location/
 
-Update device coordinates
-^^^^^^^^^^^^^^^^^^^^^^^^^
-
-.. code-block:: text
-
-    PUT /api/v1/controller/device/{id}/location/
-
-List of devices in a location
-^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+The device location endpoints can be accessed in two ways:
+""""""""""""""""""""""""""""""""""""""""""""""""""""""""""
 
-.. code:: text
+* As all the other endpoints it can be accessed
+  with token or session authentication, when this
+  happens permissions and multi-tenancy is respected.
 
-    GET /api/v1/controller/location/{id}/device/
+* When device key is passed as ``query_param``, we assume
+  the device itself is updating its position, so no check for
+  multi-tenancy or permissions is performed.
 
-List locations with devices deployed (in GeoJSON format)
-^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-
-.. code:: text
-
-    GET /api/v1/controller/location/geojson/
+Update device location
+^^^^^^^^^^^^^^^^^^^^^^
 
-You can filter using ``organization_slug`` to list location of
-devices from that organization
+.. code-block:: text
 
-.. code:: text
+    PUT /api/v1/controller/device/{id}/location/
 
-    GET /api/v1/controller/location/geojson/?organization_slug=<organization_slug>
+**Note**:- To access this endpoints, `see here <#the-device-location-endpoints-can-be-accesseed-in-two-ways>`_
 
+Patch details of device location
+^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
-List devices with location
-^^^^^^^^^^^^^^^^^^^^^^^^^^
+.. code-block:: text
 
-.. code:: text
+    PATCH /api/v1/controller/device/{id}/location/
 
-    GET /api/v1/geo/devicelocation/
+**Note**:- To access this endpoints, `see here <#the-device-location-endpoints-can-be-accesseed-in-two-ways>`_
 
-Add location to device
+Delete device location
 ^^^^^^^^^^^^^^^^^^^^^^
 
-.. code:: text
-
-    POST /api/v1/geo/devicelocation/
+.. code-block:: text
 
-Get devices with location detail
-^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+    DELETE /api/v1/controller/device/{id}/location/
 
-.. code:: text
+**Note**:- To access this endpoints, `see here <#the-device-location-endpoints-can-be-accesseed-in-two-ways>`_.
+Presently, with these endpoints it is not possible to
+assign an existing location or floorplan to a device,
+however, it allows us to update and delete.
 
-    GET /api/v1/geo/devicelocation/{id}/
-
-Change device location detail
+List of devices in a location
 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
 .. code:: text
 
-    PUT /api/v1/geo/devicelocation/{id}/
-
-Patch device location detail
-^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-
-.. code:: text
-
-    PATCH /api/v1/geo/devicelocation/{id}/
+    GET /api/v1/controller/location/{id}/device/
 
-Delete device location
-^^^^^^^^^^^^^^^^^^^^^^
+List locations with devices deployed (in GeoJSON format)
+^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
 .. code:: text
 
-    DELETE /api/v1/geo/devicelocation/{id}/
+    GET /api/v1/controller/location/geojson/
 
 List floorplan
 ^^^^^^^^^^^^^^
 
 .. code:: text
 
-    GET /api/v1/geo/floorplan/
+    GET /api/v1/controller/floorplan/
 
 Create floorplan
 ^^^^^^^^^^^^^^^^
 
 .. code:: text
 
-    POST /api/v1/geo/floorplan/
+    POST /api/v1/controller/floorplan/
 
 Get floorplan detail
 ^^^^^^^^^^^^^^^^^^^^
 
 .. code:: text
 
-    GET /api/v1/geo/floorplan/{pk}/
+    GET /api/v1/controller/floorplan/{pk}/
 
 Change floorplan detail
 ^^^^^^^^^^^^^^^^^^^^^^^
 
 .. code:: text
 
-    PUT /api/v1/geo/floorplan/{pk}/
+    PUT /api/v1/controller/floorplan/{pk}/
 
 Patch details of floorplan
 ^^^^^^^^^^^^^^^^^^^^^^^^^^
 
 .. code:: text
 
-    PATCH /api/v1/geo/floorplan/{pk}/
+    PATCH /api/v1/controller/floorplan/{pk}/
 
 Delete floorplan
 ^^^^^^^^^^^^^^^^
 
 .. code:: text
 
-    DELETE /api/v1/geo/floorplan/{pk}/
+    DELETE /api/v1/controller/floorplan/{pk}/
 
 List locations
 ^^^^^^^^^^^^^^
 
 .. code:: text
 
-    GET /api/v1/geo/location/
+    GET /api/v1/controller/location/
 
 Create locations
 ^^^^^^^^^^^^^^^^
 
 .. code:: text
 
-    POST /api/v1/geo/location/
+    POST /api/v1/controller/location/
 
 Get location detail
 ^^^^^^^^^^^^^^^^^^^
 
 .. code:: text
 
-    GET /api/v1/geo/location/{pk}/
+    GET /api/v1/controller/location/{pk}/
 
 Change location detail
 ^^^^^^^^^^^^^^^^^^^^^^
 
 .. code:: text
 
-    PUT /api/v1/geo/location/{pk}/
+    PUT /api/v1/controller/location/{pk}/
 
 Patch details of location
 ^^^^^^^^^^^^^^^^^^^^^^^^^
 
 .. code:: text
 
-    PATCH /api/v1/geo/location/{pk}/
+    PATCH /api/v1/controller/location/{pk}/
+
+**Note**: Only the first floorplan data present can be
+edited or changed. Setting the `type` of location to
+outdoor will remove all the floorplans associated with it.
+
+**Example usage**: To change the floorplan data of a location
+
+.. code-block:: shell
+
+    echo '{"floorplan":{"floor": 11}}' | \
+    http PATCH http://127.0.0.1:8000/api/v1/controller/location/76b7d9cc-4ffd-4a43-b1b0-8f8befd1a7c0/
 
 Delete location
 ^^^^^^^^^^^^^^^
 
 .. code:: text
 
-    DELETE /api/v1/geo/location/{pk}/
+    DELETE /api/v1/controller/location/{pk}/
+
+List device groups
+^^^^^^^^^^^^^^^^^^
+
+.. code:: text
+
+    GET api/v1/controller/group/
+
+Create device group
+^^^^^^^^^^^^^^^^^^^
+
+.. code:: text
+
+    POST api/v1/controller/group/
+
+Get device group detail
+^^^^^^^^^^^^^^^^^^^^^^^
+
+.. code-block:: text
+
+    GET /api/v1/controller/group/{id}/
+
+Get device group from certificate common name
+^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+
+.. code-block:: text
+
+    GET /api/v1/controller/cert/{common_name}/group/
+
+This endpoint can be used to retrieve group information and metadata by the
+common name of a certificate used in a VPN client tunnel, this endpoint is
+used in layer 2 tunneling solutions for firewall/captive portals.
+
+It is also possible to filter device group by providing organization slug
+of certificate's organization as show in the example below:
+
+.. code-block:: text
+
+    GET /api/v1/controller/cert/{common_name}/group/?org={org1_slug},{org2_slug}
 
 List templates
 ^^^^^^^^^^^^^^

openwisp_controller/config/api/views.py

@@ -121,10 +121,7 @@ class DeviceGroupDetailView(ProtectedAPIMixin, RetrieveUpdateDestroyAPIView):
 
 
 def get_cached_devicegroup_args_rewrite(cls, org_slugs, common_name):
-    url = reverse(
-        'config_api:devicegroup_x509_commonname',
-        args=[common_name],
-    )
+    url = reverse('config_api:devicegroup_x509_commonname', args=[common_name])
     url = f'{url}?org={org_slugs}'
     return url
 
@@ -184,11 +181,7 @@ def _invalidate_from_queryset(cls, queryset):
     @classmethod
     def device_change_invalidates_cache(cls, device_id):
         qs = (
-            VpnClient.objects.select_related(
-                'config',
-                'organization',
-                'cert',
-            )
+            VpnClient.objects.select_related('config', 'organization', 'cert',)
             .filter(config__device_id=device_id)
             .annotate(
                 organization__slug=F('cert__organization__slug'),

openwisp_controller/connection/api/views.py

@@ -12,6 +12,8 @@
 from swapper import load_model
 
 from openwisp_users.api.authentication import BearerAuthentication
+from openwisp_users.api.mixins import FilterByOrganizationManaged
+from openwisp_users.api.permissions import DjangoModelPermissions
 
 from ...mixins import ProtectedAPIMixin
 from .serializer import (