-
-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix slice/Hashable overlap. Update mypy and pyright #1021
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great seeing far fewer ignore comments :)
@twoertwein updates based on your comments for you to review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, looks good to me! Just need to rebase
done in commit b5ba2ed |
Thank you @Dr-Irv ! |
Also makes stubs compliant with mypy 1.13.0 and pyright 1.1.387 .