Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nightly CI with split case for pandas (around 3.0.0 version) #975

Merged
merged 12 commits into from
Aug 8, 2024

Conversation

loicdiridollou
Copy link
Contributor

tests/test_utility.py Show resolved Hide resolved
tests/test_utility.py Outdated Show resolved Hide resolved
tests/test_utility.py Outdated Show resolved Hide resolved
@loicdiridollou
Copy link
Contributor Author

@Dr-Irv I tried to clean up the test but the context is dependent on pandas<3.0 and numpy>=2.0 so that makes the logic a little crooked. I improved it but there is no way to have all the show_versions at once (since in one case it will raise a UserWarning and not in another).
Let me know if you find a better way to write those, I was not overly familiar with the logic at first so did not want to break it all.

tests/test_utility.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @loicdiridollou . Let's see what happens after I merge

@Dr-Irv Dr-Irv merged commit 2acc94d into pandas-dev:main Aug 8, 2024
13 checks passed
@loicdiridollou
Copy link
Contributor Author

thanks @loicdiridollou . Let's see what happens after I merge

Fingers crossed!

@Dr-Irv
Copy link
Collaborator

Dr-Irv commented Aug 8, 2024

thanks @loicdiridollou . Let's see what happens after I merge

Fingers crossed!

It succeeded. Thanks for looking into this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restore nightly CI build due to new pandas version (3.0.0)
2 participants