Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support pyright 376 #979

Merged
merged 3 commits into from
Aug 20, 2024
Merged

Support pyright 376 #979

merged 3 commits into from
Aug 20, 2024

Conversation

Dr-Irv
Copy link
Collaborator

@Dr-Irv Dr-Irv commented Aug 19, 2024

  • remove pyright overrides not needed with pyright 1.1.374 #967 created fixes for pyright 1.1.374, but that was a buggy version of pyright, so pyright 1.1.376 has it right, so had to undo that PR
  • Upgraded my laptop to Windows 11 and had intermittent issues with the test_plotting.py tests, so copied over some code from the pandas repo to handle that

@Dr-Irv Dr-Irv requested a review from twoertwein August 19, 2024 23:54
@Dr-Irv
Copy link
Collaborator Author

Dr-Irv commented Aug 20, 2024

Had to lock numpy to 2.0.1 because with numpy 2.1, we are getting fails now, and as my luck goes, numpy 2.1 was released yesterday.

@Dr-Irv Dr-Irv mentioned this pull request Aug 20, 2024
Merged
@twoertwein twoertwein merged commit 9c20865 into pandas-dev:main Aug 20, 2024
13 checks passed
@twoertwein
Copy link
Member

Thanks @Dr-Irv !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twoertwein twoertwein twoertwein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dr-Irv @twoertwein