Skip to content

Commit

Permalink
Group root commands as cache always breaks anyhow
Browse files Browse the repository at this point in the history
  • Loading branch information
consideRatio committed Mar 18, 2021
1 parent f309b52 commit c6a7e7a
Showing 1 changed file with 11 additions and 13 deletions.
24 changes: 11 additions & 13 deletions base-image/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,8 @@ ENTRYPOINT ["/srv/start"]
# Only run these if used as a base image
# ----------------------
ONBUILD USER root
# hardcode for now
# FIXME (?): user and home folder is hardcoded for now
# FIXME (?): this line breaks the cache of all steps below
ONBUILD COPY --chown=jovyan:jovyan . /home/jovyan

ONBUILD RUN echo "Checking for 'binder' or '.binder' subfolder" \
Expand All @@ -82,6 +83,15 @@ ONBUILD RUN echo "Checking for 'apt.txt'..." \
&& rm -rf /var/lib/apt/lists/* \
; fi

# Copy jupyter_notebook_config.py to /etc/jupyter
ONBUILD RUN echo "Checking for 'jupyter_notebook_config.py'..." \
; [ -d binder ] && cd binder \
; [ -d .binder ] && cd .binder \
; if test -f "jupyter_notebook_config.py" ; then \
mkdir -p /etc/jupyter \
&& cp jupyter_notebook_config.py /etc/jupyter \
; fi

ONBUILD USER ${NB_USER}

# Create "notebook" conda environment and dask labextensions
Expand Down Expand Up @@ -134,16 +144,4 @@ ONBUILD RUN echo "Checking for 'start'..." \
chmod +x start \
&& cp start /srv/start \
; fi

# Copy jupyter_notebook_config.py to /etc/jupyter, which is an action not done
# with repo2docker.
ONBUILD USER root
ONBUILD RUN echo "Checking for config 'jupyter_notebook_config.py'..." \
; [ -d binder ] && cd binder \
; [ -d .binder ] && cd .binder \
; if test -f "jupyter_notebook_config.py" ; then \
mkdir -p /etc/jupyter \
&& cp jupyter_notebook_config.py /etc/jupyter \
; fi
ONBUILD USER ${NB_USER}
# ----------------------

0 comments on commit c6a7e7a

Please sign in to comment.