Bulk delete consolidated dimensions before writing. #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rabernat I can confirm that this solved the outstanding issue in an e2e test. The fix in |
rabernat
approved these changes
Sep 2, 2022
There was a problem hiding this comment.
Perfect, thanks for this fix!
One tiny nit...then LGTM.
The test failures are totally unrelated and look like some sort of packaging headache that I hope just goes away by itself. Happy to merge this without fixing that for now, since all the upstream_dev tests are green.
Co-authored-by: Ryan Abernathey <[email protected]>
Co-authored-by: Ryan Abernathey <[email protected]>
|
Actually it looks like all the python 3.9 tests are failing. WTF is going on. I'm going to merge this and then try to fix that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #406