Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate pangeo-forge-recipes<0.10.0 support #144

Open
cisaacstern opened this issue Nov 18, 2023 · 1 comment
Open

Deprecate pangeo-forge-recipes<0.10.0 support #144

cisaacstern opened this issue Nov 18, 2023 · 1 comment
Assignees

Comments

@cisaacstern
Copy link
Member

Not a super high priority, but noting that supporting 0.9.4 adds a lot of CI overhead, and branching logic in the code. I would be very surprised to learn that anyone is actively deploying recipes written with <0.10.0 with pangeo-forge-runner, but as good practice probably best to do a deprecation cycle over the course of a few releases?

@moradology
Copy link
Contributor

moradology commented Feb 12, 2024

I'd be in favor of asking forgiveness rather than making things bulletproof. Perhaps just gut the relevant portions and add an exception that very clearly and very quickly alerts users to the need to upgrade?

Work in this direction on #170

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants