Upgrade Flink #150
Merged
Upgrade Flink #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranchodeluxe
added
the
test-flink
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #150 +/- ##
=======================================
Coverage 96.36% 96.36%
=======================================
Files 15 15
Lines 495 495
=======================================
Hits 477 477
Misses 18 18 ☔ View full report in Codecov by Sentry. |
cisaacstern
reviewed
Nov 21, 2023
.github/workflows/flink.yaml
Outdated
| "pangeo-forge-recipes==0.9.4", | ||
| "pangeo-forge-recipes==0.10.0", |
There was a problem hiding this comment.
@ranchodeluxe generally I like deprecating 0.9.4 support (#144) but for my understanding, is there a reason this is part of this PR?
There was a problem hiding this comment.
And thanks for the lightening-fast turnaround on this!
There was a problem hiding this comment.
oh, haha, we can change it back so you can do the deprecation sorry (just thought I'd add it in)
cisaacstern
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #149
NOTE: the companion PR to upgrade the operator for the TF repo will stay with the historyserver updates