Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): Conflicts issue fix #61

Open
wants to merge 50 commits into
base: master
Choose a base branch
from
Open

fix(ios): Conflicts issue fix #61

wants to merge 50 commits into from

Conversation

pankaj-pp
Copy link
Owner

No description provided.

Emanuel Luayza and others added 30 commits August 6, 2019 11:20
And set some custom data. The loader should be initialized after the video is set (first time) and when the host (activity) resumes. It should be released when the host is paused or destroyed.
Using onTouchListener to know whether the button was clicked. We cannot use the regular onClickListener because that will mask the SDK functionality of the button.
Again, use the OnTouchListener instead of OnClick listener in order to avoid overriding the SDK functionality of the button.
On a regular interval X (3 seconds), send the amount of "play" time during X, meaning subtracting the pause time during X from X.
LoadVideo was being called when multiple meta-data is set causing video impression to be sent multiple times against one play event, causing the view rate to drop to 50%.
No need to call loadVideo after setting the playerId, the important thing is that the playerId is set to analytics
No need to call loadVideo after setting the videoToken if it is null
Perform check on Policy Key before fetching the video
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants