Use Nix and put the CI for contributors #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kachick
commented
Jul 16, 2023
Comment on lines
+3
to
+12
| pull_request: | ||
| paths: | ||
| - '.github/workflows/ci-nix.yml' | ||
| - '*.nix' | ||
| - 'flake.*' | ||
| schedule: | ||
| # Every 10:42 JST | ||
| # https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#schedule | ||
| - cron: '42 1 * * *' | ||
| workflow_dispatch: |
There was a problem hiding this comment.
基本控えめな契機にしつつ、定時実行だけ入れさせてもらいました。本当は Makefile の変更とかも引っ掛けたいけど、他のCIに比べて重めなのでストレスにならんようにと
kachick
commented
Jul 16, 2023
| - uses: DeterminateSystems/magic-nix-cache-action@v2 | ||
| - run: nix flake check | ||
| - run: nix develop --command echo 'This step should be done before any other "nix develop" steps because of measuring Nix build time' | ||
| - run: nix develop --command make all |
There was a problem hiding this comment.
これに伴って make の task 一つで良いので増やしてそれを走らせると便利そう
kachick
commented
Jul 16, 2023
Comment on lines
+1
to
+10
| { | ||
| "editor.defaultFormatter": "dprint.dprint", | ||
| "editor.formatOnSave": true, | ||
| "[nix]": { | ||
| "editor.defaultFormatter": "jnoortheen.nix-ide" | ||
| }, | ||
| "[go]": { | ||
| "editor.defaultFormatter": "golang.go" | ||
| } | ||
| } |
There was a problem hiding this comment.
置かせてもらえると嬉しいけれど、 vim 党として許せないと言うなら已む無し
There was a problem hiding this comment.
感謝～ 😂
それか、 .vscode を gitignore に入れちゃって、後はお前ら勝手にやれというのも一つの手なんだろうなぁ
pankona
reviewed
Jul 16, 2023
| dprint | ||
| actionlint | ||
| nil | ||
| nixpkgs-fmt |
There was a problem hiding this comment.
その辺は home-manager で使ってるのよね～
というより、このリポジトリとして依存してないならここに入れない方が良いかなーという部分なんですが、どっかつかってましたっけ
Makefile しかみてない
There was a problem hiding this comment.
EDITOR=vim
makefile にあったわ
There was a problem hiding this comment.
vim をこういうとこ入れるって初耳だけど入れてみた
pankona
approved these changes
Jul 16, 2023
|
:yoshi: |
|
あざます！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
目出度くコミット権限を頂いたので、早速 Nix 環境を置かせてもらおうかなと・・・
cc: kachick/times_kachick#221 今まではこうメモってた