Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace dart-sass-embedded with dart-sass #277

Merged
merged 2 commits into from
Apr 4, 2024
Merged

Replace dart-sass-embedded with dart-sass #277

merged 2 commits into from
Apr 4, 2024

Conversation

kachick
Copy link
Collaborator

@kachick kachick commented Apr 4, 2024

sass/dart-sass-embedded@4190c31

ref #276, but cannot fixed

Summary by CodeRabbit

  • Chores
    • Dart Sassのインストールコマンドを"dart-sass-embedded"から"dart-sass"に更新しました。

Copy link

coderabbitai bot commented Apr 4, 2024

Warning

Rate Limit Exceeded

@kachick has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 25 minutes and 20 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits Files that changed from the base of the PR and between 122e50c and c228b0c.

Walkthrough

この変更の要点は、GitHub Actionsのワークフロー内でDart Sassのインストールコマンドをdart-sass-embeddedからdart-sassに更新することです。この変更は、デプロイプロセス中のインストール時間を短縮することを目的としています。

Changes

ファイル 変更概要
.github/workflows/.../generate_site_and_deploy.yaml Dart Sassのインストールコマンドをdart-sass-embeddedからdart-sassに更新

Assessment against linked issues

Objective Addressed Explanation
#276: sudo snap install dart-sass-embedded takes long time in deploy

🐰
さあ、変更を祝おう、速くなるよ
コードの海を、軽やかに跳ねる
更新された命令、輝く未来へ
素早く変わる、我々の世界
🌟✨🚀🌈
-- コードラビットより

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Status

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between a061222 and 122e50c.
Files selected for processing (1)
  • .github/workflows/generate_site_and_deploy.yaml (1 hunks)
Additional comments not posted (1)
.github/workflows/generate_site_and_deploy.yaml (1)

39-39: sudo snap install dart-sass コマンドを使用して Dart Sass をインストールする変更を承認しますが、"dart-sass" が snap パッケージとして利用可能であり、追加の設定手順が必要ないことを確認してください。

@kachick
Copy link
Collaborator Author

kachick commented Apr 4, 2024

変更前の https://github.com/pankona/pankona.github.com/actions/runs/8552414145/job/23433467578 とか14秒で終わってるのにこのCIは中々終わってなかったり30秒ぐらいで終わるときもあったり・・・

dart-sass に変えては置いたほうがサポート状況という意味で良さそうだけれど、速度的な話には寄与しなさそうです!

@kachick
Copy link
Collaborator Author

kachick commented Apr 4, 2024

actions/runner-images#998
actions/runner-images#2209

関係あるかも

@kachick kachick merged commit e6e0f51 into main Apr 4, 2024
6 checks passed
@kachick kachick deleted the update-dart-sass branch April 4, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant