Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump and pin to NixOS 24.05 nixpkgs #291

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Bump and pin to NixOS 24.05 nixpkgs #291

merged 1 commit into from
Jul 4, 2024

Conversation

kachick
Copy link
Collaborator

@kachick kachick commented Jul 4, 2024

Before

> make deps
nix --version
nix (Nix) 2.21.2
hugo version
hugo v0.124.1+extended linux/amd64 BuildDate=unknown VendorInfo=nixpkgs
go version
go version go1.22.1 linux/amd64
make --version
GNU Make 4.4.1
Built for x86_64-pc-linux-gnu
Copyright (C) 1988-2023 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <https://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
dprint --version
dprint 0.45.0
typos --version
typos-cli 1.16.23
convert --version
Version: ImageMagick 7.1.1-29 Q16-HDRI x86_64 cfc71f0aa:20240225 https://imagemagick.org
Copyright: (C) 1999 ImageMagick Studio LLC
License: https://imagemagick.org/script/license.php
Features: Cipher DPC HDRI OpenMP(4.5)
Delegates (built-in): bzlib cairo djvu fontconfig freetype heic jng jp2 jpeg jxl lcms lqr lzma openexr pangocairo png raw rsvg tiff webp x xml zlib zstd
Compiler: gcc (12.3)
actionlint --version
1.6.26
installed by building from source
built with go1.21.8 compiler for linux/amd64
ls --version
ls (GNU coreutils) 9.3
Packaged by https://nixos.org
Copyright (C) 2023 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <https://gnu.org/licenses/gpl.html>.
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Written by Richard M. Stallman and David MacKenzie.
nil --version
nil 2023-08-09
peco --version
peco version v0.5.11 (built with go1.21.8)
vim --version | sed -n '1p'
VIM - Vi IMproved 9.0 (2022 Jun 28, compiled Jan 01 1980 00:00:00)

After

> make deps
nix --version
nix (Nix) 2.21.2
hugo version
hugo v0.126.1+extended linux/amd64 BuildDate=unknown VendorInfo=nixpkgs
go version
go version go1.22.4 linux/amd64
make --version
GNU Make 4.4.1
Built for x86_64-pc-linux-gnu
Copyright (C) 1988-2023 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <https://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
dprint --version
dprint 0.45.1
typos --version
typos-cli 1.21.0
convert --version
Version: ImageMagick 7.1.1-32 Q16-HDRI x86_64 e1de8c5eb:20240505 https://imagemagick.org
Copyright: (C) 1999 ImageMagick Studio LLC
License: https://imagemagick.org/script/license.php
Features: Cipher DPC HDRI OpenMP(4.5)
Delegates (built-in): bzlib cairo djvu fontconfig freetype heic jng jp2 jpeg jxl lcms lqr lzma openexr pangocairo png raw rsvg tiff webp x xml zlib zstd
Compiler: gcc (13.2)
actionlint --version
1.7.0
installed by building from source
built with go1.22.4 compiler for linux/amd64
ls --version
ls (GNU coreutils) 9.5
Packaged by https://nixos.org
Copyright (C) 2024 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <https://gnu.org/licenses/gpl.html>.
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Written by Richard M. Stallman and David MacKenzie.
nil --version
nil 2023-08-09
peco --version
peco version v0.5.11 (built with go1.22.4)
vim --version | sed -n '1p'
VIM - Vi IMproved 9.1 (2024 Jan 02, compiled Jan 01 1980 00:00:00)

Summary by CodeRabbit

  • Chores
    • Updated dependencies to use stable versions of dprint, hugo, and go_1_22.
    • Removed references to edge-nixpkgs for improved stability.

Copy link

coderabbitai bot commented Jul 4, 2024

Walkthrough

The flake.nix file has been updated to modernize dependencies by changing the versions of nixpkgs and removing the edge-nixpkgs references. Additionally, specific dependencies (edge-pkgs.dprint, edge-pkgs.hugo, and edge-pkgs.go_1_22) have been replaced with their stable counterparts (dprint, hugo, and go_1_22). This streamlines the setup and ensures a more stable and manageable configuration.

Changes

File Change Summary
flake.nix Updated versions of nixpkgs, removed edge-nixpkgs references, and replaced specific dependencies

Poem

In a file named 'flake.nix' we see,
Dependencies neat as can be.
Edge packages farewell, the new ones excel,
Hugo, Dprint, and Go ring the bell.
A stable setup we now cheer, 💻 🌟
Flakes and flakes, there's nothing to fear!


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 9de63be and 4ab246b.

Files ignored due to path filters (1)
  • flake.lock is excluded by !**/*.lock
Files selected for processing (1)
  • flake.nix (3 hunks)
Additional comments not posted (6)
flake.nix (6)

4-4: Verify compatibility with nixos-24.05.

The nixpkgs URL has been updated to nixos-24.05. Ensure that this version is compatible with the rest of the configuration and dependencies.


31-31: Verify resolution of dprint dependency.

The dprint dependency has been updated. Ensure that it is correctly resolved and compatible with the rest of the configuration.


33-33: Verify resolution of hugo dependency.

The hugo dependency has been updated. Ensure that it is correctly resolved and compatible with the rest of the configuration.


34-34: Verify resolution of go_1_22 dependency.

The go_1_22 dependency has been updated. Ensure that it is correctly resolved and compatible with the rest of the configuration.


46-46: Verify resolution of hugo dependency within apps.

The hugo dependency has been updated within the apps section. Ensure that it is correctly resolved and compatible with the rest of the configuration.


47-47: Verify resolution of go_1_22 dependency within apps.

The go_1_22 dependency has been updated within the apps section. Ensure that it is correctly resolved and compatible with the rest of the configuration.

@kachick
Copy link
Collaborator Author

kachick commented Jul 4, 2024

#279 以来、この手の変更は実際のデプロイ時に使われる hugo のバージョンにも影響します。
つまりレビュー時一番気にするべきところは

hugo v0.124.1+extended linux/amd64 BuildDate=unknown VendorInfo=nixpkgs

hugo v0.126.1+extended linux/amd64 BuildDate=unknown VendorInfo=nixpkgs

になることなんですが、 ローカルでの make serve 的に大きな差分はなさそうな感じでした

@kachick kachick merged commit 42be825 into main Jul 4, 2024
6 checks passed
@kachick kachick deleted the nixos-24 branch July 4, 2024 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant