Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing Japanese punctuation mark #310

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Add missing Japanese punctuation mark #310

merged 1 commit into from
Sep 13, 2024

Conversation

kachick
Copy link
Collaborator

@kachick kachick commented Sep 13, 2024

Summary by CodeRabbit

  • Bug Fixes

    • Improved the readability of the title in the book log post by adding a comma.
  • Documentation

    • No changes were made to the content of the document; the overall message remains intact.

Copy link

coderabbitai bot commented Sep 13, 2024

Walkthrough

The pull request introduces a minor textual adjustment in the title of a markdown file. Specifically, a comma was added to the phrase "だいたいのことは," enhancing its readability. The content of the document remains unchanged, preserving the original context and message.

Changes

File Change Summary
content/posts/book-log-on-combat.md Title punctuation changed from "だいたいのことは" to "だいたいのことは、"

Poem

In the garden where words bloom bright,
A comma danced, a small delight.
With a gentle pause, the title sings,
Enhancing tales that reading brings.
Hoppy joy in each little change,
A world of meaning, sweet and strange! 🐇✨

Tip

OpenAI O1 model for chat
  • We have deployed OpenAI's latest O1 model for chat.
  • OpenAI claims that this model has superior reasoning capabilities than their GPT-4o model.
  • Please share any feedback with us in the discussions post.

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 2d3cade and 5664df3.

Files selected for processing (1)
  • content/posts/book-log-on-combat.md (1 hunks)
Files skipped from review due to trivial changes (1)
  • content/posts/book-log-on-combat.md

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@@ -34,4 +34,3 @@ categories: ["本"]
なんだけど、この本を読んだあと、こういう症状が起こるのは (人によって程度こそ異なるものの) だいたい普通、つまり「極めて自然」であるというような認識になってきた。説明できる現象なのである。びびるのは普通なのである。本はあくまで「戦闘」の話を綴っているわけなので、だいぶ拡大解釈ではあるかもしれないが。

日々のプレッシャーを感じるとき、あるいは自己嫌悪に陥りそうなとき、心の中で「いやまあしかし、こう思っちゃうのって人間にとって "極めて自然" だしな、しゃーないよな」って思えると、ちょっと気が楽になるような気がせんでもない。"極めて自然"、心に飼っておこうと思った。

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

自分のエディタの Autoformat でこれが入ってしまった・・・

@pankona dprint を 記事の markdown にかけたりするのどう思います?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

いいと思います!が、イシュードリブンで書くこのブログの仕組みに微妙にミートしないような気がしないでもない、が、自動でコミットするところまでいけばよさそうかも!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

それはそう

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

自動でコミットするところまでいけばよさそう

PR出しておきました。 #311

@@ -1,6 +1,6 @@
---
title: >-
「戦争の心理学」という本を読んだらだいたいのことは "極めて自然" に思えてきた
「戦争の心理学」という本を読んだら、だいたいのことは "極めて自然" に思えてきた
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kachick/times_kachick#304 とかのRSSリーダー試すときにこのサイトのRSS使ってたら極めて自然じゃないタイトルに感じました!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mecab を使ったらもとのタイトルでも解析はできてそうなので、好みの問題なのか・・・?

130! nix run nixpkgs/nixos-24.05#mecab -- --version
mecab of 0.996
1! nix run nixpkgs/nixos-24.05#mecab
メロスは激怒した。
メロス	名詞,一般,*,*,*,*,*
は	助詞,係助詞,*,*,*,*,は,ハ,ワ
激怒	名詞,サ変接続,*,*,*,*,激怒,ゲキド,ゲキド
し	動詞,自立,*,*,サ変・スル,連用形,する,シ,シ
た	助動詞,*,*,*,特殊・タ,基本形,た,タ,タ
。	記号,句点,*,*,*,*,。,。,。
EOS
「戦争の心理学」という本を読んだらだいたいのことは "極めて自然" に思えてきた
「	記号,括弧開,*,*,*,*,「,「,「
戦争	名詞,サ変接続,*,*,*,*,戦争,センソウ,センソー
の	助詞,連体化,*,*,*,*,の,ノ,ノ
心理	名詞,一般,*,*,*,*,心理,シンリ,シンリ
学	名詞,接尾,一般,*,*,*,学,ガク,ガク
」	記号,括弧閉,*,*,*,*,」,」,」
という	助詞,格助詞,連語,*,*,*,という,トイウ,トユウ
本	名詞,一般,*,*,*,*,本,ホン,ホン
を	助詞,格助詞,一般,*,*,*,を,ヲ,ヲ
読ん	動詞,自立,*,*,五段・マ行,連用タ接続,読む,ヨン,ヨン
だら	助動詞,*,*,*,特殊・タ,仮定形,だ,ダラ,ダラ
だいたい	名詞,一般,*,*,*,*,だいたい,ダイタイ,ダイタイ
の	助詞,連体化,*,*,*,*,の,ノ,ノ
こと	名詞,非自立,一般,*,*,*,こと,コト,コト
は	助詞,係助詞,*,*,*,*,は,ハ,ワ
"	名詞,サ変接続,*,*,*,*,*
極めて	副詞,一般,*,*,*,*,極めて,キワメテ,キワメテ
自然	名詞,形容動詞語幹,*,*,*,*,自然,シゼン,シゼン
"	名詞,サ変接続,*,*,*,*,*
に	助詞,格助詞,一般,*,*,*,に,ニ,ニ
思え	動詞,自立,*,*,一段,連用形,思える,オモエ,オモエ
て	助詞,接続助詞,*,*,*,*,て,テ,テ
き	動詞,非自立,*,*,カ変・クル,連用形,くる,キ,キ
た	助動詞,*,*,*,特殊・タ,基本形,た,タ,タ
EOS
「戦争の心理学」という本を読んだら、だいたいのことは "極めて自然" に思えてきた
「	記号,括弧開,*,*,*,*,「,「,「
戦争	名詞,サ変接続,*,*,*,*,戦争,センソウ,センソー
の	助詞,連体化,*,*,*,*,の,ノ,ノ
心理	名詞,一般,*,*,*,*,心理,シンリ,シンリ
学	名詞,接尾,一般,*,*,*,学,ガク,ガク
」	記号,括弧閉,*,*,*,*,」,」,」
という	助詞,格助詞,連語,*,*,*,という,トイウ,トユウ
本	名詞,一般,*,*,*,*,本,ホン,ホン
を	助詞,格助詞,一般,*,*,*,を,ヲ,ヲ
読ん	動詞,自立,*,*,五段・マ行,連用タ接続,読む,ヨン,ヨン
だら	助動詞,*,*,*,特殊・タ,仮定形,だ,ダラ,ダラ
、	記号,読点,*,*,*,*,、,、,、
だいたい	名詞,一般,*,*,*,*,だいたい,ダイタイ,ダイタイ
の	助詞,連体化,*,*,*,*,の,ノ,ノ
こと	名詞,非自立,一般,*,*,*,こと,コト,コト
は	助詞,係助詞,*,*,*,*,は,ハ,ワ
"	名詞,サ変接続,*,*,*,*,*
極めて	副詞,一般,*,*,*,*,極めて,キワメテ,キワメテ
自然	名詞,形容動詞語幹,*,*,*,*,自然,シゼン,シゼン
"	名詞,サ変接続,*,*,*,*,*
に	助詞,格助詞,一般,*,*,*,に,ニ,ニ
思え	動詞,自立,*,*,一段,連用形,思える,オモエ,オモエ
て	助詞,接続助詞,*,*,*,*,て,テ,テ
き	動詞,非自立,*,*,カ変・クル,連用形,くる,キ,キ
た	助動詞,*,*,*,特殊・タ,基本形,た,タ,タ
EOS

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

タイトルに句読点は打たないほうがいいかなーと思ってはいた。いれてもいいか

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

おまかせします!(閉じてもらっても大丈夫)

Copy link
Owner

@pankona pankona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

極めて自然

@pankona pankona merged commit a2bb6ee into main Sep 13, 2024
6 checks passed
@pankona pankona deleted the fix-japanese-title branch September 13, 2024 12:09
@kachick
Copy link
Collaborator Author

kachick commented Sep 13, 2024

あざざます!(スパイ的に自然)

@coderabbitai coderabbitai bot mentioned this pull request Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants