Merge pull request #586 from panoratech/user-duplicate-fix

feat: Rest compliance warnings in boilerplate
panoratech · Jul 30, 2024 · 9b8a44a · 9b8a44a
2 parents c335f03 + 04f261d
commit 9b8a44a
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/packages/api/scripts/commonObject.sh b/packages/api/scripts/commonObject.sh
@@ -4,6 +4,9 @@
 # THIS SCRIPT GENERATES THE BOILERPLATE FOR NEW COMMON OBJECTS
 # Usage: ./commonObject.sh "account,other_object" "accounting"
 
+# Warning: if the objectCap does not end with the letter 's'
+[[ ! $ObjectCap =~ s$ ]] && echo "Warning: ObjectCap does not end with the letter 's' - this object maybe doesn't comply with RESTful naming conventions"
+
 if [ "$#" -ne 2 ]; then
     echo "Usage: $0 <object_types_comma_separated> <vertical_object>"
     exit 1

diff --git a/packages/api/src/accounting/account/account.controller.ts b/packages/api/src/accounting/account/account.controller.ts
@@ -128,7 +128,7 @@ export class AccountController {
 
   @ApiOperation({
     operationId: 'createAccountingAccount',
-    summary: 'Accounts',
+    summary: 'Create Accounts',
     description: 'Create accounts in any supported Accounting software',
   })
   @ApiHeader({

diff --git a/packages/api/swagger/swagger-spec.yaml b/packages/api/swagger/swagger-spec.yaml
@@ -5535,7 +5535,7 @@ paths:
       x-speakeasy-group: accounting.accounts
     post:
       operationId: createAccountingAccount
-      summary: Accounts
+      summary: Create Accounts
       description: Create accounts in any supported Accounting software
       parameters:
         - name: x-connection-token