Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix connectorUpdate #466

Merged
merged 1 commit into from
May 28, 2024
Merged

Fix connectorUpdate #466

merged 1 commit into from
May 28, 2024

Conversation

mit-27
Copy link
Contributor

@mit-27 mit-27 commented May 27, 2024

No description provided.

Copy link

changeset-bot bot commented May 27, 2024

⚠️ No Changeset found

Latest commit: 04727bd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented May 27, 2024

@mit-27 is attempting to deploy a commit to the Panora Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

coderabbitai bot commented May 27, 2024

Walkthrough

The recent updates primarily focus on renaming enums and file paths in the connectorUpdate.js script and enhancing type declarations in the original.ticketing.ts file. The connectorUpdate.js script now uses "Connectors" instead of "Providers" and adjusts file paths accordingly. Similarly, original.ticketing.ts has expanded type definitions for various ticketing system inputs and outputs, adding more flexibility to the structure.

Changes

Files Change Summary
packages/api/scripts/connectorUpdate.js Updated enum names from Providers to Connectors and adjusted file paths for provider and enum files.
packages/api/src/@core/utils/types/... Enhanced type declarations for ticketing system inputs and outputs, adding more options for each type.

Poem

In the code where changes flow,
Connectors now take the show.
Paths adjusted, types refined,
Ticketing with options aligned.
Code evolves, onward we go! 🚀


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to full the review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 9016a31 and 04727bd.
Files selected for processing (2)
  • packages/api/scripts/connectorUpdate.js (3 hunks)
  • packages/api/src/@core/utils/types/original/original.ticketing.ts (4 hunks)
Additional Context Used
Biome (38)
packages/api/scripts/connectorUpdate.js (18)

10-10: A Node.js builtin module should be imported with the node: protocol.


11-11: A Node.js builtin module should be imported with the node: protocol.


12-12: A Node.js builtin module should be imported with the node: protocol.


75-75: Template literals are preferred over string concatenation.


79-120: Prefer for...of instead of forEach.


162-197: Prefer for...of instead of forEach.


201-205: Template literals are preferred over string concatenation.


251-269: Prefer for...of instead of forEach.


253-253: Template literals are preferred over string concatenation.


260-260: This regular expression contains unclear uses of consecutive spaces.


263-263: Template literals are preferred over string concatenation.


284-284: Change to an optional chain.


295-301: Prefer for...of instead of forEach.


35-35: This let declares a variable that is only assigned once.


71-71: Reassigning a function parameter is confusing.


140-140: This let declares a variable that is only assigned once.


279-279: This let declares a variable that is only assigned once.


285-285: This let declares a variable that is only assigned once.

packages/api/src/@core/utils/types/original/original.ticketing.ts (20)

2-6: All these imports are only used as types.


6-7: All these imports are only used as types.


7-8: All these imports are only used as types.


8-12: All these imports are only used as types.


12-16: All these imports are only used as types.


16-20: All these imports are only used as types.


20-24: All these imports are only used as types.


24-28: All these imports are only used as types.


28-32: All these imports are only used as types.


32-36: All these imports are only used as types.


36-40: All these imports are only used as types.


40-44: All these imports are only used as types.


44-48: All these imports are only used as types.


48-52: All these imports are only used as types.


52-56: All these imports are only used as types.


56-60: All these imports are only used as types.


60-64: All these imports are only used as types.


64-68: All these imports are only used as types.


68-72: All these imports are only used as types.


72-76: All these imports are only used as types.

Additional comments not posted (7)
packages/api/src/@core/utils/types/original/original.ticketing.ts (4)

158-160: LGTM! The expansion of OriginalAccountInput to include ZendeskAccountInput and FrontAccountInput enhances the flexibility of the type.


183-185: LGTM! The addition of JiraCollectionInput and GitlabCollectionInput to OriginalCollectionInput is a positive change, increasing its utility.


224-226: LGTM! The expansion of OriginalAccountOutput to include ZendeskAccountOutput and FrontAccountOutput is well-implemented.


256-258: LGTM! The addition of JiraCollectionOutput and GitlabCollectionOutput to OriginalCollectionOutput broadens its applicability.

packages/api/scripts/connectorUpdate.js (3)

279-279: LGTM! The update to enumName to use Connectors aligns with the renaming objective of the PR.


331-331: LGTM! The update to providersFilePath to point to connectors/index.ts is correctly implemented.


333-333: LGTM! The update to enumFilePath to point to connectors/enum.ts is correctly implemented.

@naelob naelob merged commit da25209 into panoratech:main May 28, 2024
10 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants