Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix #694

Closed
wants to merge 1 commit into from
Closed

🐛 Fix #694

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/shared/src/connectors/metadata.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2767,7 +2767,7 @@ export const CONNECTORS_METADATA: ProvidersConfig = {
authBaseUrl:`https://login.microsoftonline.com/common/oauth2/v2.0/authorize`
},
logoPath: 'https://pnghq.com/wp-content/uploads/pnghq.com-microsoft-sharepoint-logo-9.png',
description: 'Sync & Create contacts, deals, companies, notes, engagements, stages, tasks and users',
description: '',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provide a meaningful description for clarity and consistency.

Removing the detailed description reduces clarity about the connector's functionality and is inconsistent with other connector descriptions.

Consider reverting this change and providing a meaningful description, such as:

-description: '',
+description: 'Sync & Create files, folders and permissions',

Alternatively, if the description is intentionally left empty, ensure that empty descriptions are consistently applied to all other connectors. However, providing meaningful descriptions is recommended for better user understanding and documentation.

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
description: '',
description: 'Sync & Create files, folders and permissions',

active: false,
primaryColor: '',
options: {
Expand Down
Loading