KIT-41: [next-drupal] Implement Header #963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CobyPear
added
next-drupal
🦋 Changeset detectedLatest commit: 8040654 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
backlineint
approved these changes
Nov 29, 2023
There was a problem hiding this comment.
Created one styling follow up ticket that we can consider: https://getpantheon.atlassian.net/browse/KIT-136
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were made?
Implement new Header in the next-drupal-starter and the next-drupal add-ons. Search was not tested as there will be extra consideration for the header and the new search component.
When we implement the footer, we can remove the footer menu items from the layout, in the
next-drupalandnext-wptemplates.Where were the changes made?
How have the changes been tested?
Locally using the monorepo, will check again with the snapshot release version of the CLI when it is up.
Additional information
Don't forget to add a changeset if needed!