-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KIT-93: [react-kit] <Footer />
component
#977
Conversation
🦋 Changeset detectedLatest commit: f6e994a The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The horizontal space seems off in a few places - looks like the elements should make it 300px tall, currently it's at 156px.
We'll need a white version of the logo. id if it's as easy as copying the current svg and changing the fill colors or if it's more involved, you can export the svg from the Figma file.
The text sizes seem off compared to the design.
bbf7404
to
1efa1c3
Compare
Lots of updated to the structure of the component here. I played around with the styles and this should be the correct sizing now (landed at 299px tall after confirming the correct spacing was being used), the text still looks slightly different compared to the designs but I am using the specified text sizes outlined in Figma so I am not sure what that is attributed to exactly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small thing and I think this is good to go after that. Looks great!
What changes were made?
Adds an implementation of a
<Footer />
component toreact-kit
per the re-theme designs.Where were the changes made?
react-kit
How have the changes been tested?
Storybook & tests
Additional information
Don't forget to add a changeset if needed!