Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow drush sa to still work #2012

Open
wants to merge 2 commits into
base: 2.x
Choose a base branch
from
Open

Conversation

hanoii
Copy link
Contributor

@hanoii hanoii commented Sep 18, 2019

Without this, the policy will try to validate ${env-name} as a valid hostname and will failed, and the command drush sa will return the error and no aliases.

Without this, the policy will try to validate `${env-name}` as a valid hostname and will failed, and the command `drush sa` will return the error and no aliases.
@greg-1-anderson
Copy link
Member

I guess that ${env-name} is already replaced in most instances, but is not replaced when running drush sa?

The drush 9 version of this policy file will also need to be similarly adjusted.

@hanoii
Copy link
Contributor Author

hanoii commented Sep 18, 2019

@greg-1-anderson correct, I actually just tried and this on a few drush 9 sites with different versions and there it works just fine. drush actually replaces ${env-name} for * and the policy is not even run so no need to update the policy. This could also be a drush "bug", but maybe easier to also fix here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants