-
-
Notifications
You must be signed in to change notification settings - Fork 643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infer all PBS-related metadata from the URL #21789
Merged
tdyas
merged 20 commits into
pantsbuild:main
from
tdyas:pbs/infer-user-supplied-pythons
Dec 26, 2024
Merged
infer all PBS-related metadata from the URL #21789
tdyas
merged 20 commits into
pantsbuild:main
from
tdyas:pbs/infer-user-supplied-pythons
Dec 26, 2024
+412
−78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdyas
added
category:new feature
release-notes:not-required
PR doesn't require mention in release notes
labels
Dec 20, 2024
tdyas
removed
the
release-notes:not-required
PR doesn't require mention in release notes
label
Dec 20, 2024
huonw
reviewed
Dec 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really nice, feedback is just a bunch of small things
src/python/pants/backend/python/providers/python_build_standalone/rules.py
Outdated
Show resolved
Hide resolved
src/python/pants/backend/python/providers/python_build_standalone/rules.py
Outdated
Show resolved
Hide resolved
src/python/pants/backend/python/providers/python_build_standalone/rules.py
Outdated
Show resolved
Hide resolved
src/python/pants/backend/python/providers/python_build_standalone/rules.py
Outdated
Show resolved
Hide resolved
src/python/pants/backend/python/providers/python_build_standalone/rules.py
Outdated
Show resolved
Hide resolved
huonw
approved these changes
Dec 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Infer most PBS-related metadata from the artifact download URL provided by the user. (The SHA256 checksum and file size are not inferred from the URL.)
Adds a three field format for
--python-build-standalone-known-python-versions
which infers all PBS-related metadata from the URL. Format isSHA256|FILE_SIZE|URL
. The five field format is still supported.Remove the
--python-build-standalone-require-inferrable-release-tag
option added by #21739 because the PBS release tag can now be optionally provided in the version field (first field) of the five field format for--python-build-standalone-known-python-versions
.