Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infer all PBS-related metadata from the URL #21789

Merged
merged 20 commits into from
Dec 26, 2024

Conversation

tdyas
Copy link
Contributor

@tdyas tdyas commented Dec 20, 2024

Infer most PBS-related metadata from the artifact download URL provided by the user. (The SHA256 checksum and file size are not inferred from the URL.)

Adds a three field format for --python-build-standalone-known-python-versions which infers all PBS-related metadata from the URL. Format is SHA256|FILE_SIZE|URL. The five field format is still supported.

Remove the --python-build-standalone-require-inferrable-release-tag option added by #21739 because the PBS release tag can now be optionally provided in the version field (first field) of the five field format for --python-build-standalone-known-python-versions.

@tdyas tdyas added category:new feature release-notes:not-required PR doesn't require mention in release notes labels Dec 20, 2024
@tdyas tdyas removed the release-notes:not-required PR doesn't require mention in release notes label Dec 20, 2024
@tdyas tdyas requested review from cburroughs and huonw December 20, 2024 22:11
@tdyas tdyas marked this pull request as ready for review December 20, 2024 22:20
Copy link
Contributor

@huonw huonw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really nice, feedback is just a bunch of small things

Copy link
Contributor

@huonw huonw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@tdyas tdyas merged commit a2a0652 into pantsbuild:main Dec 26, 2024
24 checks passed
@tdyas tdyas deleted the pbs/infer-user-supplied-pythons branch December 26, 2024 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants