Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce export file permissions and overwrite it #308

Closed
wants to merge 2 commits into from
Closed

Reduce export file permissions and overwrite it #308

wants to merge 2 commits into from

Conversation

hubnut
Copy link
Contributor

@hubnut hubnut commented Sep 12, 2023

Also fixes "append instead of overwrite" bug in andOTP export, mentioned in issue #305

@hubnut
Replace instead of append to file when writing andOTP encrypted backup
2d2cd94
@hubnut
Create export files with minimal permissions, readable only by owner
18b59e0 
Export files are now created using a umask of 066 or, for encrypted
exports in andOTP format, glib's G_FILE_CREATE_PRIVATE flag. The default
umask is disregarded.

This is intended to reduce the risk of accidental disclosure of secrets on
multi-user systems.
paolostivanin
paolostivanin requested changes Sep 13, 2023
View reviewed changes
Copy link
Owner

@paolostivanin paolostivanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should take the opportunity to move all these file operations to g_file_replace :)

@paolostivanin paolostivanin changed the title Reduce export file permissions Reduce export file permissions and overwrite it Sep 13, 2023
@hubnut hubnut deleted the reduce-export-file-permissions branch July 20, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paolostivanin paolostivanin paolostivanin requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hubnut @paolostivanin