Rename the default database from app to paradedb #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Philippe Noël <[email protected]>
Signed-off-by: Philippe Noël <[email protected]>
Signed-off-by: Philippe Noël <[email protected]>
Signed-off-by: Philippe Noël <[email protected]>
Signed-off-by: Philippe Noël <[email protected]>
Signed-off-by: Philippe Noël <[email protected]>
Signed-off-by: Philippe Noël <[email protected]>
philippemnoel
force-pushed
the
phil/rename-database
branch
from
f1d6bb6
to
f4bfa84
Compare
|
This PR is blocked waiting for Itay to do some upstream investigation |
philippemnoel
commented
Sep 27, 2024
| @@ -101,8 +101,6 @@ Postgres UID | |||
| {{- define "cluster.postgresUID" -}} | |||
| {{- if ge (int .Values.cluster.postgresUID) 0 -}} | |||
| {{- .Values.cluster.postgresUID }} | |||
| {{- else if eq .Values.type "paradedb" -}} | |||
There was a problem hiding this comment.
I'm no longer convinced we want to remove that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default database right now is named
app. This renames it toparadedbfor branding consistency.